RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 13:32:45 +00:00
Code Issues Activity Actions

LibJS: Use RTTI for inheritance checks

Browse source 
This replaces the hand-rolled string-based inheritance check tech.
This commit is contained in:
Andreas Kling 2021-01-01 17:00:20 +01:00
parent fc86717f43
commit 8333055c3d
3 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View file

@ -639,7 +639,7 @@ static @fully_qualified_name@* impl_from(JS::VM& vm, JS::GlobalObject& global_ob
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
return {};
if (!this_object->inherits("@wrapper_class@")) {
if (!is<@wrapper_class@>(this_object)) {
vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotA, "@fully_qualified_name@");
return nullptr;
}
@ -694,7 +694,7 @@ static @fully_qualified_name@* impl_from(JS::VM& vm, JS::GlobalObject& global_ob
if (vm.exception())
@return_statement@
if (!@cpp_name@_object->inherits("@parameter.type.name@Wrapper")) {
if (!is<@parameter.type.name@Wrapper>(@cpp_name@_object)) {
vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotA, "@parameter.type.name@");
@return_statement@
}