RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 21:27:36 +00:00
Code Issues Activity Actions

LibWeb: Move setting of Web object prototypes to initialize()

Browse source 
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
This commit is contained in:
Timothy Flynn 2023-01-10 06:28:20 -05:00 • committed by Andreas Kling
parent 7bd8fd000f
commit 834202aeb9
339 changed files with 1294 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/Bindings/LocationObject.cpp
View file

@ -24,7 +24,6 @@ namespace Web::Bindings {
LocationObject::LocationObject(JS::Realm& realm)
: PlatformObject(realm)
{
set_prototype(&cached_web_prototype(realm, "Location"));
}
LocationObject::~LocationObject() = default;
@ -41,6 +40,8 @@ void LocationObject::initialize(JS::Realm& realm)
auto& vm = this->vm();
Object::initialize(realm);
set_prototype(&ensure_web_prototype<LocationPrototype>(realm, "Location"));
u8 attr = JS::Attribute::Writable | JS::Attribute::Enumerable;
define_native_accessor(realm, "href", href_getter, href_setter, attr);
define_native_accessor(realm, "host", host_getter, {}, attr);