RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 05:37:44 +00:00
Code Issues Activity Actions

LibWeb: Move setting of Web object prototypes to initialize()

Browse source 
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
This commit is contained in:
Timothy Flynn 2023-01-10 06:28:20 -05:00 • committed by Andreas Kling
parent 7bd8fd000f
commit 834202aeb9
339 changed files with 1294 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Geometry/DOMPoint.cpp
View file

@ -18,7 +18,6 @@ JS::NonnullGCPtr<DOMPoint> DOMPoint::construct_impl(JS::Realm& realm, double x,
DOMPoint::DOMPoint(JS::Realm& realm, double x, double y, double z, double w)
: DOMPointReadOnly(realm, x, y, z, w)
{
set_prototype(&Bindings::cached_web_prototype(realm, "DOMPoint"));
}
// https://drafts.fxtf.org/geometry/#dom-dompoint-frompoint
@ -30,4 +29,10 @@ JS::NonnullGCPtr<DOMPoint> DOMPoint::from_point(JS::VM& vm, DOMPointInit const&
DOMPoint::~DOMPoint() = default;
void DOMPoint::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMPointPrototype>(realm, "DOMPoint"));
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMPoint.h
View file

@ -34,6 +34,8 @@ public:
private:
DOMPoint(JS::Realm&, double x, double y, double z, double w);
virtual void initialize(JS::Realm&) override;
};
}

7
Userland/Libraries/LibWeb/Geometry/DOMPointReadOnly.cpp
View file

@ -22,7 +22,6 @@ DOMPointReadOnly::DOMPointReadOnly(JS::Realm& realm, double x, double y, double
, m_z(z)
, m_w(w)
{
set_prototype(&Bindings::cached_web_prototype(realm, "DOMPointReadOnly"));
}
// https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint
@ -34,4 +33,10 @@ JS::NonnullGCPtr<DOMPointReadOnly> DOMPointReadOnly::from_point(JS::VM& vm, DOMP
DOMPointReadOnly::~DOMPointReadOnly() = default;
void DOMPointReadOnly::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMPointReadOnlyPrototype>(realm, "DOMPointReadOnly"));
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMPointReadOnly.h
View file

@ -39,6 +39,8 @@ public:
protected:
DOMPointReadOnly(JS::Realm&, double x, double y, double z, double w);
virtual void initialize(JS::Realm&) override;
double m_x;
double m_y;
double m_z;

7
Userland/Libraries/LibWeb/Geometry/DOMRect.cpp
View file

@ -22,9 +22,14 @@ JS::NonnullGCPtr<DOMRect> DOMRect::create(JS::Realm& realm, Gfx::FloatRect const
DOMRect::DOMRect(JS::Realm& realm, double x, double y, double width, double height)
: DOMRectReadOnly(realm, x, y, width, height)
{
set_prototype(&Bindings::cached_web_prototype(realm, "DOMRect"));
}
DOMRect::~DOMRect() = default;
void DOMRect::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMRectPrototype>(realm, "DOMRect"));
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMRect.h
View file

@ -32,6 +32,8 @@ public:
private:
DOMRect(JS::Realm&, double x, double y, double width, double height);
virtual void initialize(JS::Realm&) override;
};
}

7
Userland/Libraries/LibWeb/Geometry/DOMRectReadOnly.cpp
View file

@ -18,9 +18,14 @@ DOMRectReadOnly::DOMRectReadOnly(JS::Realm& realm, double x, double y, double wi
: PlatformObject(realm)
, m_rect(x, y, width, height)
{
set_prototype(&Bindings::cached_web_prototype(realm, "DOMRectReadOnly"));
}
DOMRectReadOnly::~DOMRectReadOnly() = default;
void DOMRectReadOnly::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::DOMRectReadOnlyPrototype>(realm, "DOMRectReadOnly"));
}
}

2
Userland/Libraries/LibWeb/Geometry/DOMRectReadOnly.h
View file

@ -34,6 +34,8 @@ public:
protected:
DOMRectReadOnly(JS::Realm&, double x, double y, double width, double height);
virtual void initialize(JS::Realm&) override;
Gfx::FloatRect m_rect;
};
}