mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 12:27:36 +00:00
LibWeb: Move setting of Web object prototypes to initialize()
This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
This commit is contained in:
parent
7bd8fd000f
commit
834202aeb9
339 changed files with 1294 additions and 187 deletions
|
@ -20,11 +20,16 @@ Selection::Selection(JS::NonnullGCPtr<JS::Realm> realm, JS::NonnullGCPtr<DOM::Do
|
|||
: PlatformObject(realm)
|
||||
, m_document(document)
|
||||
{
|
||||
set_prototype(&Bindings::cached_web_prototype(realm, "Selection"));
|
||||
}
|
||||
|
||||
Selection::~Selection() = default;
|
||||
|
||||
void Selection::initialize(JS::Realm& realm)
|
||||
{
|
||||
Base::initialize(realm);
|
||||
set_prototype(&Bindings::ensure_web_prototype<Bindings::SelectionPrototype>(realm, "Selection"));
|
||||
}
|
||||
|
||||
// https://w3c.github.io/selection-api/#dfn-empty
|
||||
bool Selection::is_empty() const
|
||||
{
|
||||
|
|
|
@ -55,6 +55,7 @@ private:
|
|||
|
||||
[[nodiscard]] bool is_empty() const;
|
||||
|
||||
virtual void initialize(JS::Realm&) override;
|
||||
virtual void visit_edges(Cell::Visitor&) override;
|
||||
|
||||
// https://w3c.github.io/selection-api/#dfn-empty
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue