RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 08:17:34 +00:00
Code Issues Activity Actions

LibWeb: Move setting of Web object prototypes to initialize()

Browse source 
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
This commit is contained in:
Timothy Flynn 2023-01-10 06:28:20 -05:00 • committed by Andreas Kling
parent 7bd8fd000f
commit 834202aeb9
339 changed files with 1294 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Selection/Selection.cpp
View file

@ -20,11 +20,16 @@ Selection::Selection(JS::NonnullGCPtr<JS::Realm> realm, JS::NonnullGCPtr<DOM::Do
: PlatformObject(realm)
, m_document(document)
{
set_prototype(&Bindings::cached_web_prototype(realm, "Selection"));
}
Selection::~Selection() = default;
void Selection::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::SelectionPrototype>(realm, "Selection"));
}
// https://w3c.github.io/selection-api/#dfn-empty
bool Selection::is_empty() const
{

1
Userland/Libraries/LibWeb/Selection/Selection.h
View file

@ -55,6 +55,7 @@ private:
[[nodiscard]] bool is_empty() const;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
// https://w3c.github.io/selection-api/#dfn-empty