RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:57:35 +00:00
Code Issues Activity Actions

LibWeb: Move setting of Web object prototypes to initialize()

Browse source 
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
This commit is contained in:
Timothy Flynn 2023-01-10 06:28:20 -05:00 • committed by Andreas Kling
parent 7bd8fd000f
commit 834202aeb9
339 changed files with 1294 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/UIEvents/UIEvent.cpp
View file

@ -22,7 +22,6 @@ UIEvent* UIEvent::construct_impl(JS::Realm& realm, DeprecatedFlyString const& ev
UIEvent::UIEvent(JS::Realm& realm, DeprecatedFlyString const& event_name)
: Event(realm, event_name)
{
set_prototype(&Bindings::cached_web_prototype(realm, "UIEvent"));
}
UIEvent::UIEvent(JS::Realm& realm, DeprecatedFlyString const& event_name, UIEventInit const& event_init)
@ -30,11 +29,16 @@ UIEvent::UIEvent(JS::Realm& realm, DeprecatedFlyString const& event_name, UIEven
, m_view(event_init.view)
, m_detail(event_init.detail)
{
set_prototype(&Bindings::cached_web_prototype(realm, "UIEvent"));
}
UIEvent::~UIEvent() = default;
void UIEvent::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::UIEventPrototype>(realm, "UIEvent"));
}
void UIEvent::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);