RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibJS+WebContent+js: Bring console.count[Reset]() to spec

Browse source 
The `CountReset` log level is displayed as a warning, since the message
is always to warn that the counter doesn't exist. This is also in line
with the table at https://console.spec.whatwg.org/#loglevel-severity
This commit is contained in:
Sam Atkins 2021-12-08 19:12:06 +00:00 • committed by Andreas Kling
parent 260836135a
commit 834ced82d4
5 changed files with 50 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Utilities/js.cpp
View file

@ -1141,24 +1141,6 @@ public:
return JS::js_undefined();
}
virtual JS::Value count() override
{
auto label = vm().argument_count() ? vm().argument(0).to_string_without_side_effects() : "default";
auto counter_value = m_console.counter_increment(label);
js_outln("{}: {}", label, counter_value);
return JS::js_undefined();
}
virtual JS::Value count_reset() override
{
auto label = vm().argument_count() ? vm().argument(0).to_string_without_side_effects() : "default";
if (m_console.counter_reset(label))
js_outln("{}: 0", label);
else
js_outln("\033[33;1m\"{}\" doesn't have a count\033[0m", label);
return JS::js_undefined();
}
virtual JS::Value assert_() override
{
auto& vm = this->vm();
@ -1192,6 +1174,7 @@ public:
js_outln("{}", output);
break;
case JS::Console::LogLevel::Warn:
case JS::Console::LogLevel::CountReset:
js_outln("\033[33;1m{}\033[0m", output);
break;
default: