From 836ce8ee5d3e301d939430507141728eeca7eb18 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Wed, 24 Nov 2021 08:38:50 +0000 Subject: [PATCH] LibJS: Fix parse ErrorType used in parse_temporal_date_string() TemporalInvalidDateString, not TemporalInvalidDateTimeString. --- .../Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp | 2 +- .../Tests/builtins/Temporal/PlainDate/PlainDate.from.js | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp index 8c7d74e3d5..fb05b4cded 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/AbstractOperations.cpp @@ -1269,7 +1269,7 @@ ThrowCompletionOr parse_temporal_date_string(GlobalObject& global_ auto parse_result = parse_iso8601(Production::TemporalDateString, iso_string); if (!parse_result.has_value()) { // a. Throw a RangeError exception. - return vm.throw_completion(global_object, ErrorType::TemporalInvalidDateTimeString, iso_string); + return vm.throw_completion(global_object, ErrorType::TemporalInvalidDateString, iso_string); } // 3. Let result be ? ParseISODateTime(isoString). diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js index eed03c7233..29007334f1 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDate/PlainDate.from.js @@ -43,4 +43,10 @@ describe("errors", () => { Temporal.PlainDate.from(zonedDateTime); }).toThrowWithMessage(TypeError, "null is not a function"); }); + + test("invalid date string", () => { + expect(() => { + Temporal.PlainDate.from("foo"); + }).toThrowWithMessage(RangeError, "Invalid date string 'foo'"); + }); });