RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00
Code Issues Activity Actions

TextEditor/FileArgument: Remove file existance check for early exit

Browse source 
This check was fine earlier when we had access to the full filesystem,
but now that we are moving away from applications having unveiled
access to the filesystem, this check would just get rejected from
the kernel. This is rare / fast enough that performance should not
really matter in any case.
This commit is contained in:
Mustafa Quraish 2021-09-06 01:40:45 -04:00 • committed by Ali Mohammad Pur
parent 63ff5873d8
commit 8378ecc67b
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/TextEditor/FileArgument.cpp
View file

@ -15,12 +15,6 @@ FileArgument::FileArgument(String file_argument)
m_line = {};
m_column = {};
if (Core::File::exists(file_argument)) {
// A file exists with the full specified name, don't attempt to parse it.
m_filename = move(file_argument);
return;
}
// A file doesn't exist with the full specified name, maybe the user entered line/column coordinates?
Regex<PosixExtended> re("^(.+?)(:([0-9]+):?([0-9]+)?)?$");
RegexResult result = match(file_argument, re, PosixFlags::Global | PosixFlags::Multiline | PosixFlags::Ungreedy);