RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:47:34 +00:00
Code Issues Activity Actions

WindowServer: Flush display buffer when flashing

Browse source 
If the device requires a flush and we modify the front buffer, we need
to flush those changes to the front buffer. This makes the flashing
work using the VirtIOGPU.

Also fix a minor bug where we flushed the front buffer instead of
the back buffer after flipping, which caused the VirtIOGPU to not work
as expected when using the SDL backend and disabling buffer flipping.
This commit is contained in:
Tom 2021-07-10 11:28:26 -06:00 • committed by Andreas Kling
parent 02651f8dc6
commit 83b512789c
3 changed files with 40 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Services/WindowServer/Screen.cpp
View file

@ -413,4 +413,25 @@ void Screen::flush_display(int buffer_index)
fb_data.too_many_pending_flush_rects = false;
fb_data.pending_flush_rects.clear_with_capacity();
}
void Screen::flush_display_front_buffer(int front_buffer_index, Gfx::IntRect& rect)
{
VERIFY(m_can_device_flush_buffers);
auto scale_factor = this->scale_factor();
FBRect flush_rect {
x : (unsigned)(rect.x() * scale_factor),
y : (unsigned)(rect.y() * scale_factor),
width : (unsigned)(rect.width() * scale_factor),
height : (unsigned)(rect.height() * scale_factor)
};
if (fb_flush_buffers(m_framebuffer_fd, front_buffer_index, &flush_rect, 1) < 0) {
int err = errno;
if (err == ENOTSUP)
m_can_device_flush_buffers = false;
else
dbgln("Screen #{}: Error ({}) flushing display front buffer: {}", index(), err, strerror(err));
}
}
}