RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:57:35 +00:00
Code Issues Activity Actions

LibJS: Make WeakContainer pruning do less work

Browse source 
Instead of iterating *all* swept cells when pruning weak containers,
only iterate the cells actually *in* the container.

Also, instead of compiling a list of all swept cells, we can simply
check the Cell::state() flag to know if something should be pruned.
This commit is contained in:
Andreas Kling 2021-10-05 18:44:31 +02:00
parent 19fc225b45
commit 83bd675477
10 changed files with 39 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/WeakMap.cpp
View file

@ -23,9 +23,15 @@ WeakMap::~WeakMap()
{
}
void WeakMap::remove_swept_cells(Badge<Heap>, Span<Cell*> cells)
void WeakMap::remove_dead_cells(Badge<Heap>)
{
for (auto* cell : cells)
// FIXME: Do this in a single pass.
Vector<Cell*> to_remove;
for (auto& it : m_values) {
if (it.key->state() != Cell::State::Live)
to_remove.append(it.key);
}
for (auto* cell : to_remove)
m_values.remove(cell);
}