From 83c412ee9efa85a6949960b196327530862a0706 Mon Sep 17 00:00:00 2001
From: Karol Kosek <krkk@krkk.ct8.pl>
Date: Sat, 4 Sep 2021 12:58:50 +0200
Subject: [PATCH] SoundPlayer: Create only one playlist widget

Prior this change, opening a playlist always spawned a new widget.
This could end up with having a few the same widgets, which you couldn't
even close (besides the last one).
---
 .../SoundPlayer/SoundPlayerWidgetAdvancedView.cpp      | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp b/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp
index 47ec452630..dfe25e1507 100644
--- a/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp
+++ b/Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp
@@ -38,6 +38,10 @@ SoundPlayerWidgetAdvancedView::SoundPlayerWidgetAdvancedView(GUI::Window& window
     m_player_view = m_splitter->add<GUI::Widget>();
     m_playlist_model = adopt_ref(*new PlaylistModel());
 
+    m_playlist_widget = PlaylistWidget::construct();
+    m_playlist_widget->set_data_model(m_playlist_model);
+    m_playlist_widget->set_fixed_width(150);
+
     m_player_view->set_layout<GUI::VerticalBoxLayout>();
 
     m_play_icon = Gfx::Bitmap::try_load_from_file("/res/icons/16x16/play.png");
@@ -283,9 +287,9 @@ void SoundPlayerWidgetAdvancedView::read_playlist(StringView path)
 void SoundPlayerWidgetAdvancedView::set_playlist_visible(bool visible)
 {
     if (visible) {
-        m_playlist_widget = m_player_view->parent_widget()->add<PlaylistWidget>();
-        m_playlist_widget->set_data_model(m_playlist_model);
-        m_playlist_widget->set_fixed_width(150);
+        if (!m_playlist_widget->parent()) {
+            m_player_view->parent_widget()->add_child(*m_playlist_widget);
+        }
     } else {
         m_playlist_widget->remove_from_parent();
         m_player_view->set_max_width(window()->width());