RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:28:11 +00:00
Code Issues Activity Actions

LibWeb: Make BrowsingContext GC-allocated

Browse source 
(And BrowsingContextGroup had to come along for the ride as well.)
This solves a number of nasty reference cycles between browsing
contexts, history items, and their documents.
This commit is contained in:
Andreas Kling 2022-10-17 11:06:50 +02:00
parent 2898701459
commit 83c5ff57d8
15 changed files with 225 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/NavigationParams.h
View file

@ -47,7 +47,7 @@ struct NavigationParams {
Optional<Environment> reserved_environment;
// the browsing context to be navigated (or discarded, if a browsing context group switch occurs)
NonnullRefPtr<HTML::BrowsingContext> browsing_context;
JS::Handle<HTML::BrowsingContext> browsing_context;
// a history handling behavior
HistoryHandlingBehavior history_handling { HistoryHandlingBehavior::Default };