RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:07:34 +00:00
Code Issues Activity Actions

Kernel: Remove big lock from sys$fchown

Browse source 
This syscall doesn't access any unprotected shared data.
This commit is contained in:
Idan Horowitz 2022-04-09 22:44:01 +03:00 • committed by Andreas Kling
parent f986a3b886
commit 8458313e8a
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -69,7 +69,7 @@ enum class NeedsBigProcessLock {
S(exit_thread, NeedsBigProcessLock::Yes) \ S(exit_thread, NeedsBigProcessLock::Yes) \
S(fchdir, NeedsBigProcessLock::No) \ S(fchdir, NeedsBigProcessLock::No) \
S(fchmod, NeedsBigProcessLock::No) \ S(fchmod, NeedsBigProcessLock::No) \
S(fchown, NeedsBigProcessLock::Yes) \ S(fchown, NeedsBigProcessLock::No) \
S(fcntl, NeedsBigProcessLock::Yes) \ S(fcntl, NeedsBigProcessLock::Yes) \
S(fork, NeedsBigProcessLock::Yes) \ S(fork, NeedsBigProcessLock::Yes) \
S(fstat, NeedsBigProcessLock::No) \ S(fstat, NeedsBigProcessLock::No) \

2
Kernel/Syscalls/chown.cpp
View file

@ -13,7 +13,7 @@ namespace Kernel {
ErrorOr<FlatPtr> Process::sys$fchown(int fd, UserID uid, GroupID gid) ErrorOr<FlatPtr> Process::sys$fchown(int fd, UserID uid, GroupID gid)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); VERIFY_NO_PROCESS_BIG_LOCK(this);
TRY(require_promise(Pledge::chown)); TRY(require_promise(Pledge::chown));
auto description = TRY(open_file_description(fd)); auto description = TRY(open_file_description(fd));
TRY(description->chown(uid, gid)); TRY(description->chown(uid, gid));