RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-24 01:15:07 +00:00
Code Issues Activity Actions

LibWeb: Propagate LibVideo decoder errors to the HTMLMediaElement

Browse source
This commit is contained in:
Timothy Flynn 2023-04-22 15:11:07 -04:00 • committed by Andreas Kling
parent 9c940608fd
commit 848078aedd
3 changed files with 41 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/HTML/VideoTrack.cpp
View file

@ -51,12 +51,14 @@ VideoTrack::VideoTrack(JS::Realm& realm, JS::NonnullGCPtr<HTMLMediaElement> medi
}
};
m_playback_manager->on_decoder_error = [](auto) {
// FIXME: Propagate this error to HTMLMediaElement's error attribute.
m_playback_manager->on_decoder_error = [this](auto error) {
auto error_message = String::from_utf8(error.description()).release_value_but_fixme_should_propagate_errors();
m_media_element->set_decoder_error(move(error_message)).release_value_but_fixme_should_propagate_errors();
};
m_playback_manager->on_fatal_playback_error = [](auto) {
// FIXME: Propagate this error to HTMLMediaElement's error attribute.
m_playback_manager->on_fatal_playback_error = [this](auto error) {
auto error_message = String::from_utf8(error.string_literal()).release_value_but_fixme_should_propagate_errors();
m_media_element->set_decoder_error(move(error_message)).release_value_but_fixme_should_propagate_errors();
};
}