mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 06:17:34 +00:00
LibJS+LibWeb: Make JS::ExecutionContext protect its Web::HTML::ESO owner
We can't be nuking the ESO while its owned execution context is still on the VM's execution context stack, as that may lead to a use-after-free. This patch solves this by adding a `context_owner` field to each context and treating it as a GC root.
This commit is contained in:
parent
1fdce71483
commit
849499988e
3 changed files with 7 additions and 0 deletions
|
@ -204,6 +204,8 @@ void VM::gather_roots(HashTable<Cell*>& roots)
|
|||
roots.set(execution_context->lexical_environment);
|
||||
roots.set(execution_context->variable_environment);
|
||||
roots.set(execution_context->private_environment);
|
||||
if (auto* context_owner = execution_context->context_owner)
|
||||
roots.set(context_owner);
|
||||
execution_context->script_or_module.visit(
|
||||
[](Empty) {},
|
||||
[&](auto& script_or_module) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue