RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 07:07:34 +00:00
Code Issues Activity Actions

LibJS: Do not throw a TypeError when sorting a detached TypedArray

Browse source 
This is a normative change in the ECMA-262 spec. See:
e0c74e1
This commit is contained in:
Timothy Flynn 2022-04-07 13:14:06 -04:00 • committed by Linus Groh
parent d04a683f85
commit 84a81dd466
2 changed files with 18 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp
View file

@ -952,9 +952,6 @@ static ThrowCompletionOr<void> typed_array_merge_sort(GlobalObject& global_objec
auto value = TRY(result.to_number(global_object));
if (buffer.is_detached())
return vm.throw_completion<TypeError>(global_object, ErrorType::DetachedArrayBuffer);
if (value.is_nan())
comparison_result = 0;
else

18
Userland/Libraries/LibJS/Tests/builtins/TypedArray/TypedArray.prototype.sort.js
View file

@ -51,3 +51,21 @@ test("basic functionality", () => {
expect(typedArray[2]).toBe(1n);
});
});
test("detached buffer", () => {
TYPED_ARRAYS.forEach(T => {
const typedArray = new T(3);
typedArray[0] = 3;
typedArray[1] = 1;
typedArray[2] = 2;
typedArray.sort((a, b) => {
detachArrayBuffer(typedArray.buffer);
return a - b;
});
expect(typedArray[0]).toBeUndefined();
expect(typedArray[1]).toBeUndefined();
expect(typedArray[2]).toBeUndefined();
});
});