From 84fc498b9fe0035685d752fb43d4351a55e543ea Mon Sep 17 00:00:00 2001 From: Luke Date: Fri, 14 May 2021 22:35:37 +0100 Subject: [PATCH] Kernel/AHCI: Don't enable interrupts in the AHCIPort constructor On my bare metal machine, enabling it as this point causes it to instantly send an interrupt, and we're too early in the process to be able to handle AHCI interrupts. The interrupts were being enabled in the initialize function anyway. Confirmed to happen on: - 8086:9ca2 (Intel Corporation Wildcat Point-LP SATA Controller [AHCI Mode] (rev 03)) - 8086:3b22 (Intel Corporation 5 Series/3400 Series Chipset 6 port SATA AHCI Controller (rev 06)) --- Kernel/Storage/AHCIPort.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/Kernel/Storage/AHCIPort.cpp b/Kernel/Storage/AHCIPort.cpp index 0f7bfec115..189c9cef96 100644 --- a/Kernel/Storage/AHCIPort.cpp +++ b/Kernel/Storage/AHCIPort.cpp @@ -50,8 +50,6 @@ AHCIPort::AHCIPort(const AHCIPortHandler& handler, volatile AHCI::PortRegisters& } m_command_list_region = MM.allocate_kernel_region(m_command_list_page->paddr(), PAGE_SIZE, "AHCI Port Command List", Region::Access::Read | Region::Access::Write, Region::Cacheable::No); dbgln_if(AHCI_DEBUG, "AHCI Port {}: Command list region at {}", representative_port_index(), m_command_list_region->vaddr()); - - m_interrupt_enable.set_all(); } void AHCIPort::clear_sata_error_register() const