RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-30 05:32:07 +00:00
Code Issues Activity Actions

LibWeb: Move ARIA-related code into the Web::ARIA namespace

Browse source 
ARIA has its own spec and is not part of the DOM spec, which is what the
Web::DOM namespace is for (https://www.w3.org/TR/wai-aria-1.2/).

This allows us to stay closer to the spec with function names and don't
have to add the word "ARIA" to identifiers constantly - the namespace
now provides that clarity.
This commit is contained in:
Linus Groh 2023-01-28 22:23:16 +00:00
parent 8414734a2d
commit 8556d47240
61 changed files with 179 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -163,18 +163,18 @@ DeprecatedString const& HTMLSelectElement::type() const
return select_multiple;
}
Optional<DOM::ARIARoles::Role> HTMLSelectElement::default_role() const
Optional<ARIA::Role> HTMLSelectElement::default_role() const
{
// https://www.w3.org/TR/html-aria/#el-select-multiple-or-size-greater-1
if (has_attribute("multiple"))
return DOM::ARIARoles::Role::listbox;
return ARIA::Role::listbox;
if (has_attribute("size")) {
auto size_attribute = attribute("size").to_int();
if (size_attribute.has_value() && size_attribute.value() > 1)
return DOM::ARIARoles::Role::listbox;
return ARIA::Role::listbox;
}
// https://www.w3.org/TR/html-aria/#el-select
return DOM::ARIARoles::Role::combobox;
return ARIA::Role::combobox;
}
}