From 85868979285b69e3b0084faee7d6a73c45bcab18 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 23 Feb 2024 17:06:32 +0100 Subject: [PATCH] headless-browser: Don't choke on subframe load completions This didn't break any existing tests, but I have to do this for an upcoming test to not bring everything down. --- Userland/Utilities/headless-browser.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Utilities/headless-browser.cpp b/Userland/Utilities/headless-browser.cpp index cdd9e0d750..5990263444 100644 --- a/Userland/Utilities/headless-browser.cpp +++ b/Userland/Utilities/headless-browser.cpp @@ -303,7 +303,9 @@ static ErrorOr run_dump_test(HeadlessWebContentView& view, StringVie } else if (mode == TestMode::Text) { view.on_load_finish = [&](auto const& loaded_url) { - VERIFY(url.equals(loaded_url, URL::ExcludeFragment::Yes)); + // NOTE: We don't want subframe loads to trigger the test finish. + if (!url.equals(loaded_url, URL::ExcludeFragment::Yes)) + return; did_finish_loading = true; if (did_finish_test) loop.quit(0);