RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:37:46 +00:00
Code Issues Activity Actions

Ladybird+LibWeb+WebContent: Port the did_request_cookie IPC to String

Browse source
This commit is contained in:
Timothy Flynn 2024-01-26 11:10:15 -05:00 • committed by Andreas Kling
parent dcd9962d7b
commit 85b8971a80
14 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -2006,7 +2006,7 @@ void Document::completely_finish_loading()
String Document::cookie(Cookie::Source source)
{
return MUST(String::from_byte_string(page().client().page_did_request_cookie(m_url, source)));
return page().client().page_did_request_cookie(m_url, source);
}
void Document::set_cookie(StringView cookie_string, Cookie::Source source)

2
Userland/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp
View file

@ -1431,7 +1431,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<PendingResponse>> http_network_or_cache_fet
// FIXME: Getting to the page client reliably is way too complicated, and going via the document won't work in workers.
auto document = Bindings::host_defined_environment_settings_object(realm).responsible_document();
if (!document)
return ByteString::empty();
return String {};
return document->page().client().page_did_request_cookie(http_request->current_url(), Cookie::Source::Http);
})();

4
Userland/Libraries/LibWeb/Loader/LoadRequest.cpp
View file

@ -16,9 +16,9 @@ LoadRequest LoadRequest::create_for_url_on_page(const AK::URL& url, Page* page)
request.set_url(url);
if (page) {
ByteString cookie = page->client().page_did_request_cookie(url, Cookie::Source::Http);
auto cookie = page->client().page_did_request_cookie(url, Cookie::Source::Http);
if (!cookie.is_empty())
request.set_header("Cookie", cookie);
request.set_header("Cookie", cookie.to_byte_string());
request.set_page(*page);
}

2
Userland/Libraries/LibWeb/Page/Page.h
View file

@ -264,7 +264,7 @@ public:
virtual void page_did_request_dismiss_dialog() { }
virtual Vector<Web::Cookie::Cookie> page_did_request_all_cookies(AK::URL const&) { return {}; }
virtual Optional<Web::Cookie::Cookie> page_did_request_named_cookie(AK::URL const&, ByteString const&) { return {}; }
virtual ByteString page_did_request_cookie(const AK::URL&, Cookie::Source) { return {}; }
virtual String page_did_request_cookie(const AK::URL&, Cookie::Source) { return {}; }
virtual void page_did_set_cookie(const AK::URL&, Cookie::ParsedCookie const&, Cookie::Source) { }
virtual void page_did_update_cookie(Web::Cookie::Cookie) { }
virtual void page_did_update_resource_count(i32) { }

4
Userland/Libraries/LibWebView/CookieJar.cpp
View file

@ -80,7 +80,7 @@ CookieJar::CookieJar(TransientStorage storage)
{
}
ByteString CookieJar::get_cookie(const URL& url, Web::Cookie::Source source)
String CookieJar::get_cookie(const URL& url, Web::Cookie::Source source)
{
purge_expired_cookies();
@ -100,7 +100,7 @@ ByteString CookieJar::get_cookie(const URL& url, Web::Cookie::Source source)
builder.appendff("{}={}", cookie.name, cookie.value);
}
return builder.to_byte_string();
return MUST(builder.to_string());
}
void CookieJar::set_cookie(const URL& url, Web::Cookie::ParsedCookie const& parsed_cookie, Web::Cookie::Source source)

2
Userland/Libraries/LibWebView/CookieJar.h
View file

@ -49,7 +49,7 @@ public:
static ErrorOr<CookieJar> create(Database&);
static CookieJar create();
ByteString get_cookie(const URL& url, Web::Cookie::Source source);
String get_cookie(const URL& url, Web::Cookie::Source source);
void set_cookie(const URL& url, Web::Cookie::ParsedCookie const& parsed_cookie, Web::Cookie::Source source);
void update_cookie(Web::Cookie::Cookie);
void dump_cookies();

2
Userland/Libraries/LibWebView/ViewImplementation.h
View file

@ -153,7 +153,7 @@ public:
Function<void(i32 start_index, Vector<ByteString> const& message_types, Vector<ByteString> const& messages)> on_received_console_messages;
Function<Vector<Web::Cookie::Cookie>(AK::URL const& url)> on_get_all_cookies;
Function<Optional<Web::Cookie::Cookie>(AK::URL const& url, ByteString const& name)> on_get_named_cookie;
Function<ByteString(const AK::URL& url, Web::Cookie::Source source)> on_get_cookie;
Function<String(const AK::URL& url, Web::Cookie::Source source)> on_get_cookie;
Function<void(const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source)> on_set_cookie;
Function<void(Web::Cookie::Cookie const& cookie)> on_update_cookie;
Function<void(i32 count_waiting)> on_resource_status_change;

2
Userland/Libraries/LibWebView/WebContentClient.cpp
View file

@ -313,7 +313,7 @@ Messages::WebContentClient::DidRequestCookieResponse WebContentClient::did_reque
{
if (m_view.on_get_cookie)
return m_view.on_get_cookie(url, static_cast<Web::Cookie::Source>(source));
return ByteString {};
return String {};
}
void WebContentClient::did_set_cookie(AK::URL const& url, Web::Cookie::ParsedCookie const& cookie, u8 source)