RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:27:43 +00:00
Code Issues Activity Actions

LibJS: Simplify Array.prototype.splice()

Browse source 
This is an editorial change in the ECMA-262 spec.

See: 193211a
This commit is contained in:
Linus Groh 2022-04-30 22:44:00 +02:00
parent 5a26a547db
commit 85c16452f9
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -1389,9 +1389,8 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayPrototype::splice)
for (u64 i = 0; i < actual_delete_count; ++i) {
auto from = actual_start + i;
bool from_present = TRY(this_object->has_property(from));
if (from_present) {
if (TRY(this_object->has_property(from))) {
auto from_value = TRY(this_object->get(from));
TRY(removed_elements->create_data_property_or_throw(i, from_value));
@ -1405,9 +1404,7 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayPrototype::splice)
auto to = i + insert_count;
u64 from = i + actual_delete_count;
auto from_present = TRY(this_object->has_property(from));
if (from_present) {
if (TRY(this_object->has_property(from))) {
auto from_value = TRY(this_object->get(from));
TRY(this_object->set(to, from_value, Object::ShouldThrowExceptions::Yes));
} else {
@ -1420,11 +1417,9 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayPrototype::splice)
} else if (insert_count > actual_delete_count) {
for (u64 i = initial_length - actual_delete_count; i > actual_start; --i) {
u64 from_index = i + actual_delete_count - 1;
auto from_present = TRY(this_object->has_property(from_index));
auto to = i + insert_count - 1;
if (from_present) {
if (TRY(this_object->has_property(from_index))) {
auto from_value = TRY(this_object->get(from_index));
TRY(this_object->set(to, from_value, Object::ShouldThrowExceptions::Yes));
} else {