RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:17:35 +00:00
Code Issues Activity Actions

LibWeb: Port CSS/Serialize.{h,cpp} to new Strings, and propagate errors

Browse source
This commit is contained in:
Sam Atkins 2023-02-14 20:50:41 +00:00 • committed by Tim Flynn
parent a0b1eddc56
commit 85f3de6331
10 changed files with 108 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/Parser/Declaration.cpp
View file

@ -23,7 +23,7 @@ ErrorOr<String> Declaration::to_string() const
{
StringBuilder builder;
serialize_an_identifier(builder, m_name);
TRY(serialize_an_identifier(builder, m_name));
TRY(builder.try_append(": "sv));
TRY(builder.try_join(' ', m_values));

2
Userland/Libraries/LibWeb/CSS/Parser/Function.cpp
View file

@ -22,7 +22,7 @@ ErrorOr<String> Function::to_string() const
{
StringBuilder builder;
serialize_an_identifier(builder, m_name);
TRY(serialize_an_identifier(builder, m_name));
TRY(builder.try_append('('));
TRY(builder.try_join(' ', m_values));
TRY(builder.try_append(')'));

12
Userland/Libraries/LibWeb/CSS/Parser/Token.cpp
View file

@ -18,26 +18,26 @@ ErrorOr<String> Token::to_string() const
case Type::EndOfFile:
return String {};
case Type::Ident:
return String::from_utf8(serialize_an_identifier(ident()));
return serialize_an_identifier(ident());
case Type::Function:
return String::formatted("{}(", serialize_an_identifier(function()));
return String::formatted("{}(", TRY(serialize_an_identifier(function())));
case Type::AtKeyword:
return String::formatted("@{}", serialize_an_identifier(at_keyword()));
return String::formatted("@{}", TRY(serialize_an_identifier(at_keyword())));
case Type::Hash: {
switch (m_hash_type) {
case HashType::Id:
return String::formatted("#{}", serialize_an_identifier(hash_value()));
return String::formatted("#{}", TRY(serialize_an_identifier(hash_value())));
case HashType::Unrestricted:
return String::formatted("#{}", hash_value());
}
VERIFY_NOT_REACHED();
}
case Type::String:
return String::from_utf8(serialize_a_string(string()));
return serialize_a_string(string());
case Type::BadString:
return String {};
case Type::Url:
return String::from_utf8(serialize_a_url(url()));
return serialize_a_url(url());
case Type::BadUrl:
return String::from_utf8("url()"sv);
case Type::Delim: