RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:07:36 +00:00
Code Issues Activity Actions

Kernel: Use default con/de-structors

Browse source 
This may seem like a no-op change, however it shrinks down the Kernel by a bit:
.text -432
.unmap_after_init -60
.data -480
.debug_info -673
.debug_aranges 8
.debug_ranges -232
.debug_line -558
.debug_str -308
.debug_frame -40

With '= default', the compiler can do more inlining, hence the savings.
I intentionally omitted some opportunities for '= default', because they
would increase the Kernel size.
This commit is contained in:
Ben Wiederhake 2021-02-28 14:42:08 +01:00 • committed by Andreas Kling
parent 2dea887e8f
commit 860a3bbce3
28 changed files with 33 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Storage/Partition/GUIDPartitionTable.h
View file

@ -37,7 +37,8 @@ namespace Kernel {
struct GUIDPartitionHeader;
class GUIDPartitionTable final : public MBRPartitionTable {
public:
virtual ~GUIDPartitionTable() {};
virtual ~GUIDPartitionTable() = default;
;
static Result<NonnullOwnPtr<GUIDPartitionTable>, PartitionTable::Error> try_to_initialize(const StorageDevice&);
explicit GUIDPartitionTable(const StorageDevice&);

2
Kernel/Storage/Partition/PartitionTable.h
View file

@ -52,7 +52,7 @@ public:
Optional<DiskPartitionMetadata> partition(unsigned index);
size_t partitions_count() const { return m_partitions.size(); }
virtual Type type() const = 0;
virtual ~PartitionTable() { }
virtual ~PartitionTable() = default;
virtual bool is_valid() const = 0;
Vector<DiskPartitionMetadata> partitions() const { return m_partitions; }