RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

WindowServer: Improve the look of menus.

Browse source 
This patch makes menus stand out a bit more from their background by using
the same kind of shading that Windows 2000 had.
This commit is contained in:
Andreas Kling 2019-04-16 17:02:26 +02:00
parent 311019d8ee
commit 86361d3d45
6 changed files with 32 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Servers/WindowServer/WSWindowFrame.cpp
View file

@ -66,11 +66,6 @@ WSWindowFrame::~WSWindowFrame()
{
}
static inline Rect menu_window_rect(const Rect& rect)
{
return rect.inflated(2, 2);
}
Rect WSWindowFrame::title_bar_rect() const
{
return { 2, 2, m_window.width() + 2, window_titlebar_height };
@ -109,10 +104,8 @@ void WSWindowFrame::paint(Painter& painter)
PainterStateSaver saver(painter);
painter.translate(rect().location());
if (m_window.type() == WSWindowType::Menu) {
painter.draw_rect(menu_window_rect(m_window.rect()), Color::LightGray);
if (m_window.type() == WSWindowType::Menu)
return;
}
if (m_window.type() == WSWindowType::WindowSwitcher)
return;
@ -193,7 +186,7 @@ static Rect frame_rect_for_window_type(WSWindowType type, const Rect& rect)
{
switch (type) {
case WSWindowType::Menu:
return menu_window_rect(rect);
return rect;
case WSWindowType::Normal:
return { rect.x() - 3, rect.y() - window_titlebar_height - 3, rect.width() + 6, rect.height() + 6 + window_titlebar_height };
case WSWindowType::WindowSwitcher: