RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

cp: Refactor copying into copy_file function

Browse source
This commit is contained in:
Aaron Malpas 2019-09-07 11:49:28 +10:00 • committed by Andreas Kling
parent 4bc6c20091
commit 86415acd6a
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/cp.cpp
View file

@ -8,6 +8,8 @@
#include <sys/stat.h> #include <sys/stat.h>
#include <unistd.h> #include <unistd.h>
bool copy_file(String, String);
int main(int argc, char** argv) int main(int argc, char** argv)
{ {
CArgsParser args_parser("cp"); CArgsParser args_parser("cp");
@ -22,30 +24,38 @@ int main(int argc, char** argv)
} }
String src_path = values[0]; String src_path = values[0];
String dst_path = values[1]; String dst_path = values[1];
return copy_file(src_path, dst_path) ? 0 : 1;
}
/**
* Copy a source file to a destination file. Returns true if successful, false
* otherwise. If there is an error, its description is output to stderr.
*/
bool copy_file(String src_path, String dst_path)
{
int src_fd = open(src_path.characters(), O_RDONLY); int src_fd = open(src_path.characters(), O_RDONLY);
if (src_fd < 0) { if (src_fd < 0) {
perror("open src"); perror("open src");
return 1; return false;
} }
struct stat src_stat; struct stat src_stat;
int rc = fstat(src_fd, &src_stat); int rc = fstat(src_fd, &src_stat);
if (rc < 0) { if (rc < 0) {
perror("stat src"); perror("stat src");
return 1; return false;
} }
if (S_ISDIR(src_stat.st_mode)) { if (S_ISDIR(src_stat.st_mode)) {
fprintf(stderr, "cp: FIXME: Copying directories is not yet supported\n"); fprintf(stderr, "cp: FIXME: Copying directories is not yet supported\n");
return 1; return false;
} }
int dst_fd = creat(dst_path.characters(), 0666); int dst_fd = creat(dst_path.characters(), 0666);
if (dst_fd < 0) { if (dst_fd < 0) {
if (errno != EISDIR) { if (errno != EISDIR) {
perror("open dst"); perror("open dst");
return 1; return false;
} }
StringBuilder builder; StringBuilder builder;
builder.append(dst_path); builder.append(dst_path);
@ -55,7 +65,7 @@ int main(int argc, char** argv)
dst_fd = creat(dst_path.characters(), 0666); dst_fd = creat(dst_path.characters(), 0666);
if (dst_fd < 0) { if (dst_fd < 0) {
perror("open dst"); perror("open dst");
return 1; return false;
} }
} }
@ -64,7 +74,7 @@ int main(int argc, char** argv)
ssize_t nread = read(src_fd, buffer, sizeof(buffer)); ssize_t nread = read(src_fd, buffer, sizeof(buffer));
if (nread < 0) { if (nread < 0) {
perror("read src"); perror("read src");
return 1; return false;
} }
if (nread == 0) if (nread == 0)
break; break;
@ -74,7 +84,7 @@ int main(int argc, char** argv)
ssize_t nwritten = write(dst_fd, bufptr, remaining_to_write); ssize_t nwritten = write(dst_fd, bufptr, remaining_to_write);
if (nwritten < 0) { if (nwritten < 0) {
perror("write dst"); perror("write dst");
return 1; return false;
} }
assert(nwritten > 0); assert(nwritten > 0);
remaining_to_write -= nwritten; remaining_to_write -= nwritten;
@ -87,10 +97,10 @@ int main(int argc, char** argv)
rc = fchmod(dst_fd, src_stat.st_mode & ~my_umask); rc = fchmod(dst_fd, src_stat.st_mode & ~my_umask);
if (rc < 0) { if (rc < 0) {
perror("fchmod dst"); perror("fchmod dst");
return 1; return false;
} }
close(src_fd); close(src_fd);
close(dst_fd); close(dst_fd);
return 0; return true;
} }