RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:27:46 +00:00
Code Issues Activity Actions

LibJS: Move Console ownership from GlobalObject to ConsoleObject

Browse source 
GlobalObject is now a regular object with no special properties :^)
This commit is contained in:
Linus Groh 2022-08-28 14:20:06 +01:00
parent 78eca3ae64
commit 867ad03995
7 changed files with 53 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/GlobalObject.h
View file

@ -22,8 +22,6 @@ public:
virtual ~GlobalObject() override;
Console& console() { return *m_console; }
private:
virtual bool is_global_object() const final { return true; }
@ -39,8 +37,6 @@ private:
JS_DECLARE_NATIVE_FUNCTION(decode_uri_component);
JS_DECLARE_NATIVE_FUNCTION(escape);
JS_DECLARE_NATIVE_FUNCTION(unescape);
NonnullOwnPtr<Console> m_console;
};
inline GlobalObject* Shape::global_object() const