RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:47:45 +00:00
Code Issues Activity Actions

LibJS: Move Console ownership from GlobalObject to ConsoleObject

Browse source 
GlobalObject is now a regular object with no special properties :^)
This commit is contained in:
Linus Groh 2022-08-28 14:20:06 +01:00
parent 78eca3ae64
commit 867ad03995
7 changed files with 53 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -15,6 +15,7 @@
#include <LibJS/Heap/Heap.h>
#include <LibJS/Interpreter.h>
#include <LibJS/Parser.h>
#include <LibJS/Runtime/ConsoleObject.h>
#include <LibWeb/Bindings/MainThreadVM.h>
#include <LibWeb/Cookie/ParsedCookie.h>
#include <LibWeb/DOM/Document.h>
@ -389,9 +390,10 @@ void ConnectionFromClient::initialize_js_console(Badge<PageHost>)
if (m_interpreter.ptr() == interpreter.ptr())
return;
auto& console_object = *interpreter->realm().intrinsics().console_object();
m_interpreter = interpreter;
m_console_client = make<WebContentConsoleClient>(interpreter->realm().global_object().console(), interpreter, *this);
interpreter->realm().global_object().console().set_client(*m_console_client.ptr());
m_console_client = make<WebContentConsoleClient>(console_object.console(), interpreter, *this);
console_object.console().set_client(*m_console_client.ptr());
}
void ConnectionFromClient::js_console_input(String const& js_source)