RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:07:36 +00:00
Code Issues Activity Actions

LibWeb: Use grid item *outer* size when calculating minimum contribution

Browse source 
Previously we used the border box, which meant that tracks did not grow
to accommodate item margins.
This commit is contained in:
Andreas Kling 2023-06-12 14:30:00 +02:00
parent 741c7aef21
commit 867e04768e
4 changed files with 33 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/grid/grid-row-height-affected-by-item-margins.txt Normal file
View file

@ -0,0 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x97.817501 [BFC] children: not-inline
Box <body> at (10,10) content-size 780x79.817501 [GFC] children: not-inline
BlockContainer <h1> at (55.5,32.440000) content-size 689x34.9375 [BFC] children: inline
line 0 width: 492.96875, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 31, rect: [55.5,32.440000 492.96875x34.9375]
"Null publishes fine indie games"
TextNode <#text>