From 868bd2e43d0322b6e0d4536c4e7dea721c559f8d Mon Sep 17 00:00:00 2001 From: asynts Date: Sun, 16 Aug 2020 19:17:22 +0200 Subject: [PATCH] LibCrypto: Call bytes() explicitly instead of implicitly. This was a careless mistake. https://github.com/SerenityOS/serenity/pull/3166#discussion_r471131732 --- Libraries/LibCrypto/Cipher/AES.h | 2 +- Libraries/LibCrypto/Cipher/Cipher.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibCrypto/Cipher/AES.h b/Libraries/LibCrypto/Cipher/AES.h index 895f0f7e11..cb9649f397 100644 --- a/Libraries/LibCrypto/Cipher/AES.h +++ b/Libraries/LibCrypto/Cipher/AES.h @@ -55,7 +55,7 @@ public: virtual const ByteBuffer& data() const override { return m_data; }; virtual void overwrite(ReadonlyBytes) override; - virtual void overwrite(const ByteBuffer& buffer) override { overwrite(buffer); } + virtual void overwrite(const ByteBuffer& buffer) override { overwrite(buffer.bytes()); } virtual void overwrite(const u8* data, size_t size) override { overwrite({ data, size }); } virtual void apply_initialization_vector(const u8* ivec) override diff --git a/Libraries/LibCrypto/Cipher/Cipher.h b/Libraries/LibCrypto/Cipher/Cipher.h index c94b8b0b79..713030916b 100644 --- a/Libraries/LibCrypto/Cipher/Cipher.h +++ b/Libraries/LibCrypto/Cipher/Cipher.h @@ -65,7 +65,7 @@ public: virtual const ByteBuffer& data() const = 0; virtual void overwrite(ReadonlyBytes) = 0; - virtual void overwrite(const ByteBuffer& buffer) { overwrite(buffer); } + virtual void overwrite(const ByteBuffer& buffer) { overwrite(buffer.bytes()); } virtual void overwrite(const u8* data, size_t size) { overwrite({ data, size }); } virtual void apply_initialization_vector(const u8* ivec) = 0;