RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:07:35 +00:00
Code Issues Activity Actions

LibWeb: Extract common path in definite row/column placement in GFC

Browse source 
Moves the code that identifies (start, end, span) for a grid item into
a separate function. By doing so, we can eliminate the duplicated code
between the placement of grid items with definite columns and those
with definite rows.

This change omits some of the comments that reference the spec, as they
were largely irrelevant and unhelpful for making changes or diagnosing
issues.
This commit is contained in:
Aliaksandr Kalenik 2024-03-06 15:49:04 +01:00 • committed by Andreas Kling
parent 0243278587
commit 8695a82c56
2 changed files with 90 additions and 211 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Layout/GridFormattingContext.h
View file

@ -255,6 +255,13 @@ private:
void build_grid_areas();
struct PlacementPosition {
int start { 0 };
int end { 0 };
size_t span { 1 };
};
PlacementPosition resolve_grid_position(Box const& child_box, GridDimension const dimension);
void place_grid_items();
void place_item_with_row_and_column_position(Box const& child_box);
void place_item_with_row_position(Box const& child_box);