RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:17:34 +00:00
Code Issues Activity Actions

LibWeb: Assign hypothetical flex item main sizes as temporary main size

Browse source 
This colors a bit outside the lines of the specification, but the spec
doesn't offer a proper explanation for how descendants of a flex item
are supposed to have access to the flex item's main size for purposes
of percentage resolution.

The approach I came up with here was to take the hypothetical main size
of each flex item, and assign it as a temporary main size. This allows
percentage resolution in descendants to work against the pre-flexing
main size of items. This seems to match how other engines behave,
although it feels somewhat dirty. If/when we learn more about this,
we can come up with something nicer.
This commit is contained in:
Andreas Kling 2022-10-15 09:26:30 +02:00
parent 6bb738c1b3
commit 869b322a8f
3 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -301,6 +301,16 @@ void LayoutState::UsedValues::set_content_height(float height)
m_has_definite_height = true;
}
void LayoutState::UsedValues::set_temporary_content_width(float width)
{
m_content_width = width;
}
void LayoutState::UsedValues::set_temporary_content_height(float height)
{
m_content_height = height;
}
float LayoutState::resolved_definite_width(Box const& box) const
{
return get(box).content_width();