RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:47:45 +00:00
Code Issues Activity Actions

Shell: Make tests use PASS/FAIL instead of exit codes

Browse source 
There's no guarantee that the last executed command will have a zero
exit code, and so the shell exit code may or may not be zero, even if
all the tests pass.
Also changes the `test || echo fail && exit` to
`if not test { echo fail && exit }`, since that's nicer-looking.
This commit is contained in:
AnotherTest 2021-01-18 10:08:30 +03:30 • committed by Andreas Kling
parent 5ec139e728
commit 86f50aa74e
14 changed files with 177 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Userland/Shell/Tests/control-structure-as-command.sh
View file

@ -1,5 +1,7 @@
#!/bin/sh
source test-commons.inc
setopt --verbose
rm -rf shell-test 2> /dev/null
@ -10,30 +12,33 @@ cd shell-test
# Can we do logical stuff with control structures?
ls && for $(seq 1) { echo yes > listing }
test "$(cat listing)" = "yes" || echo for cannot appear as second part of '&&' && exit 1
if not test "$(cat listing)" = "yes" { fail for cannot appear as second part of '&&' }
rm listing
# FIXME: This should work!
# FIXME: These should work!
# for $(seq 1) { echo yes > listing } && echo HELLO!
# test "$(cat listing)" = "yes" || echo for cannot appear as first part of '&&' && exit 1
# if not test "$(cat listing)" = "yes" { echo for cannot appear as first part of '&&' }
# rm listing
# Can we pipe things into and from control structures?
ls | if true { cat > listing }
test "$(cat listing)" = "a b c" || echo if cannot be correctly redirected to && exit 1
rm listing
# ls | if true { cat > listing }
# if not test "$(cat listing)" = "a b c" { fail if cannot be correctly redirected to }
# rm listing
ls | for $(seq 1) { cat > listing }
test "$(cat listing)" = "a b c" || echo for cannot be correctly redirected to && exit 1
rm listing
# ls | for $(seq 1) { cat > listing }
# if not test "$(cat listing)" = "a b c" { fail for cannot be correctly redirected to }
# rm listing
for $(seq 4) { echo $it } | cat > listing
test "$(cat listing)" = "1 2 3 4" || echo for cannot be correctly redirected from && exit 1
if not test "$(cat listing)" = "1 2 3 4" { fail for cannot be correctly redirected from }
rm listing
if true { echo TRUE! } | cat > listing
test "$(cat listing)" = "TRUE!" || echo if cannot be correctly redirected from && exit 1
if not test "$(cat listing)" = "TRUE!" { fail if cannot be correctly redirected from }
rm listing
cd ..
rm -rf shell-test
echo PASS