mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 17:17:44 +00:00
AK: Serialize URL hosts with 'concept-host-serializer'
In order to follow spec text to achieve this, we need to change the underlying representation of a host in AK::URL to deserialized format. Before this, we were parsing the host and then immediately serializing it again. Making that change resulted in a whole bunch of fallout. After this change, callers can access the serialized data through this concept-host-serializer. The functional end result of this change is that IPv6 hosts are now correctly serialized to be surrounded with '[' and ']'.
This commit is contained in:
parent
768f070b86
commit
8751be09f9
36 changed files with 175 additions and 143 deletions
|
@ -2316,8 +2316,7 @@ DeprecatedString Document::domain() const
|
|||
return DeprecatedString::empty();
|
||||
|
||||
// 3. Return effectiveDomain, serialized.
|
||||
// FIXME: Implement host serialization.
|
||||
return effective_domain.release_value();
|
||||
return URLParser::serialize_host(effective_domain.release_value()).release_value_but_fixme_should_propagate_errors().to_deprecated_string();
|
||||
}
|
||||
|
||||
void Document::set_domain(DeprecatedString const& domain)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue