RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:07:35 +00:00
Code Issues Activity Actions

LibWeb+Browser: Use the new HTML parser by default

Browse source 
You can still run the old parser with "br -O", but the new one is good
enough to be the default parser now. We'll fix issues as we go and
eventually remove the old one completely. :^)
This commit is contained in:
Andreas Kling 2020-06-01 19:07:38 +02:00
parent 517cf65c99
commit 8766e49a7c
5 changed files with 13 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Applications/Browser/Tab.cpp
View file

@ -59,7 +59,7 @@
namespace Browser {
extern bool g_use_new_html_parser;
extern bool g_use_old_html_parser;
extern String g_home_url;
Tab::Tab()
@ -71,7 +71,7 @@ Tab::Tab()
auto& toolbar = m_toolbar_container->add<GUI::ToolBar>();
m_page_view = widget.add<Web::PageView>();
m_page_view->set_use_new_parser(g_use_new_html_parser);
m_page_view->set_use_old_parser(g_use_old_html_parser);
m_go_back_action = GUI::CommonActions::make_go_back_action([this](auto&) {
m_history.go_back();

4
Applications/Browser/main.cpp
View file

@ -45,7 +45,7 @@ namespace Browser {
static const char* bookmarks_filename = "/home/anon/bookmarks.json";
String g_home_url;
bool g_use_new_html_parser = false;
bool g_use_old_html_parser = false;
}
@ -64,7 +64,7 @@ int main(int argc, char** argv)
const char* specified_url = nullptr;
Core::ArgsParser args_parser;
args_parser.add_option(Browser::g_use_new_html_parser, "Use new HTML parser", "new-parser", 'n');
args_parser.add_option(Browser::g_use_old_html_parser, "Use old HTML parser", "old-parser", 'O');
args_parser.add_positional_argument(specified_url, "URL to open", "url", Core::ArgsParser::Required::No);
args_parser.parse(argc, argv);