mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 11:17:35 +00:00
LibCoreDump: Make for_each_memory_region_info() callback arg a reference
It's never nullptr, so it should be a reference.
This commit is contained in:
parent
8ec1da2fca
commit
87f1f69dd2
2 changed files with 5 additions and 5 deletions
|
@ -110,9 +110,9 @@ Optional<uint32_t> Reader::peek_memory(FlatPtr address) const
|
|||
const ELF::Core::MemoryRegionInfo* Reader::region_containing(FlatPtr address) const
|
||||
{
|
||||
const ELF::Core::MemoryRegionInfo* ret = nullptr;
|
||||
for_each_memory_region_info([&ret, address](const ELF::Core::MemoryRegionInfo* region_info) {
|
||||
if (region_info->region_start <= address && region_info->region_end >= address) {
|
||||
ret = region_info;
|
||||
for_each_memory_region_info([&ret, address](const ELF::Core::MemoryRegionInfo& region_info) {
|
||||
if (region_info.region_start <= address && region_info.region_end >= address) {
|
||||
ret = ®ion_info;
|
||||
return IterationDecision::Break;
|
||||
}
|
||||
return IterationDecision::Continue;
|
||||
|
|
|
@ -81,8 +81,8 @@ void Reader::for_each_memory_region_info(Func func) const
|
|||
for (NotesEntryIterator it((const u8*)m_coredump_image.program_header(m_notes_segment_index).raw_data()); !it.at_end(); it.next()) {
|
||||
if (it.type() != ELF::Core::NotesEntryHeader::Type::MemoryRegionInfo)
|
||||
continue;
|
||||
auto* region = (const ELF::Core::MemoryRegionInfo*)(it.current());
|
||||
IterationDecision decision = func(region);
|
||||
auto& memory_region_info = reinterpret_cast<const ELF::Core::MemoryRegionInfo&>(*it.current());
|
||||
IterationDecision decision = func(memory_region_info);
|
||||
if (decision == IterationDecision::Break)
|
||||
return;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue