RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:17:44 +00:00
Code Issues Activity Actions

LibCoreDump: Make for_each_memory_region_info() callback arg a reference

Browse source 
It's never nullptr, so it should be a reference.
This commit is contained in:
Linus Groh 2020-12-28 16:26:03 +01:00 • committed by Andreas Kling
parent 8ec1da2fca
commit 87f1f69dd2
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibCoreDump/Reader.h
View file

@ -81,8 +81,8 @@ void Reader::for_each_memory_region_info(Func func) const
for (NotesEntryIterator it((const u8*)m_coredump_image.program_header(m_notes_segment_index).raw_data()); !it.at_end(); it.next()) {
if (it.type() != ELF::Core::NotesEntryHeader::Type::MemoryRegionInfo)
continue;
auto* region = (const ELF::Core::MemoryRegionInfo*)(it.current());
IterationDecision decision = func(region);
auto& memory_region_info = reinterpret_cast<const ELF::Core::MemoryRegionInfo&>(*it.current());
IterationDecision decision = func(memory_region_info);
if (decision == IterationDecision::Break)
return;
}