RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:07:34 +00:00
Code Issues Activity Actions

LibWeb: Change IDL::parse_interface's return type to NonnullOwnPtr

Browse source 
We always returned an interface, so there's no need for the null state.
This commit is contained in:
Idan Horowitz 2021-09-28 23:10:49 +03:00
parent 2020ced9f1
commit 87f655f2af
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator.cpp
View file

@ -167,7 +167,7 @@ struct Interface {
bool is_legacy_platform_object() const { return !extended_attributes.contains("Global") && (supports_indexed_properties() || supports_named_properties()); } bool is_legacy_platform_object() const { return !extended_attributes.contains("Global") && (supports_indexed_properties() || supports_named_properties()); }
}; };
static OwnPtr<Interface> parse_interface(StringView filename, StringView const& input) static NonnullOwnPtr<Interface> parse_interface(StringView filename, StringView const& input)
{ {
auto interface = make<Interface>(); auto interface = make<Interface>();
@ -619,11 +619,6 @@ int main(int argc, char** argv)
auto data = file_or_error.value()->read_all(); auto data = file_or_error.value()->read_all();
auto interface = IDL::parse_interface(path, data); auto interface = IDL::parse_interface(path, data);
if (!interface) {
warnln("Cannot parse {}", path);
return 1;
}
if (namespace_.is_one_of("CSS", "DOM", "HTML", "UIEvents", "Geometry", "HighResolutionTime", "NavigationTiming", "RequestIdleCallback", "SVG", "XHR", "URL")) { if (namespace_.is_one_of("CSS", "DOM", "HTML", "UIEvents", "Geometry", "HighResolutionTime", "NavigationTiming", "RequestIdleCallback", "SVG", "XHR", "URL")) {
StringBuilder builder; StringBuilder builder;
builder.append(namespace_); builder.append(namespace_);