From 880504e51d67219a67f2a78a0d8d65818e360bf0 Mon Sep 17 00:00:00 2001
From: Andreas Kling <kling@serenityos.org>
Date: Fri, 3 Mar 2023 10:39:37 +0100
Subject: [PATCH] TerminalSettings: Spruce up the "View" tab a bit

- Use sentence style capitalization for CheckBox and GroupBox titles.
- Move the terminal font to the top.
- Split the cursor settings into two GroupBoxes (one for the shape,
  and one for the blinking behavior).
---
 .../TerminalSettings/TerminalSettingsView.gml | 77 +++++++++++--------
 1 file changed, 44 insertions(+), 33 deletions(-)

diff --git a/Userland/Applications/TerminalSettings/TerminalSettingsView.gml b/Userland/Applications/TerminalSettings/TerminalSettingsView.gml
index a94bb10889..a63b48a207 100644
--- a/Userland/Applications/TerminalSettings/TerminalSettingsView.gml
+++ b/Userland/Applications/TerminalSettings/TerminalSettingsView.gml
@@ -6,23 +6,7 @@
     }
 
     @GUI::GroupBox {
-        title: "Background Opacity"
-        preferred_height: "fit"
-        layout: @GUI::VerticalBoxLayout {
-            margins: [8]
-            spacing: 8
-        }
-
-        @GUI::HorizontalOpacitySlider {
-            name: "background_opacity_slider"
-            min: 0
-            max: 255
-            orientation: "Horizontal"
-        }
-    }
-
-    @GUI::GroupBox {
-        title: "Terminal Font"
+        title: "Terminal font"
         preferred_height: "fit"
         layout: @GUI::VerticalBoxLayout {
             margins: [8]
@@ -59,30 +43,57 @@
     }
 
     @GUI::GroupBox {
-        title: "Cursor Settings"
+        title: "Background opacity"
         preferred_height: "fit"
         layout: @GUI::VerticalBoxLayout {
             margins: [8]
+            spacing: 8
         }
 
-        @GUI::RadioButton {
-            name: "terminal_cursor_block"
-            text: "Block cursor"
+        @GUI::HorizontalOpacitySlider {
+            name: "background_opacity_slider"
+            min: 0
+            max: 255
+            orientation: "Horizontal"
+        }
+    }
+
+    @GUI::Widget {
+        preferred_height: "shrink"
+        layout: @GUI::HorizontalBoxLayout {}
+
+        @GUI::GroupBox {
+            title: "Cursor shape"
+            layout: @GUI::VerticalBoxLayout {
+                margins: [8]
+            }
+
+            @GUI::RadioButton {
+                name: "terminal_cursor_block"
+                text: "Block"
+            }
+
+            @GUI::RadioButton {
+                name: "terminal_cursor_underline"
+                text: "Underscore"
+            }
+
+            @GUI::RadioButton {
+                name: "terminal_cursor_bar"
+                text: "Vertical bar"
+            }
         }
 
-        @GUI::RadioButton {
-            name: "terminal_cursor_underline"
-            text: "Underline cursor"
-        }
+        @GUI::GroupBox {
+            title: "Cursor behavior"
+            layout: @GUI::VerticalBoxLayout {
+                margins: [8]
+            }
 
-        @GUI::RadioButton {
-            name: "terminal_cursor_bar"
-            text: "Bar cursor"
-        }
-
-        @GUI::CheckBox {
-            name: "terminal_cursor_blinking"
-            text: "Blinking cursor"
+            @GUI::CheckBox {
+                name: "terminal_cursor_blinking"
+                text: "Blink cursor"
+            }
         }
     }
 }