RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 00:57:43 +00:00
Code Issues Activity Actions

LibWeb: Layout inside of flex items at the end of FFC layout

Browse source 
Instead of doing internal child layout incrementally as we go, save it
for the end of flex layout. The code will become simpler if we can focus
on simply computing the dimensions of each flex item while we're doing
the main FFC algorithm.
This commit is contained in:
Andreas Kling 2022-02-27 10:01:38 +01:00
parent 7c5b578df9
commit 88302b0dca
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -148,6 +148,18 @@ void FlexFormattingContext::run(Box const& run_box, LayoutMode)
// 16. Align all flex lines (per align-content)
align_all_flex_lines();
// AD-HOC: Layout the inside of all flex items.
for (auto& flex_item : m_flex_items) {
auto independent_formatting_context = layout_inside(flex_item.box, LayoutMode::Default);
independent_formatting_context->parent_context_did_dimension_child_root_box();
}
// FIXME: We run the "align all flex lines" step *again* here, in order to override any sizes
// assigned to the flex item by the "layout inside" step above. This is definitely not
// part of the spec, and simply covering up the fact that our inside layout currently
// mutates the height of BFC roots.
align_all_flex_lines();
}
void FlexFormattingContext::populate_specified_margins(FlexItem& item, CSS::FlexDirection flex_direction) const