RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:18:12 +00:00
Code Issues Activity Actions

LibGUI: Remove unused check

Browse source 
This check was removed as it will now never trigger.

The completion has the suffix ': ' on it, and the key does not.
Therefore if the user has not yet typed the ':', it will not be equal,
and after they do the check on line 167 will fail so the entry won't be
in the list to begin with.
This commit is contained in:
thislooksfun 2021-10-26 22:07:09 -05:00 • committed by Andreas Kling
parent 9a70ae1593
commit 8863fe5852
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/GMLAutocompleteProvider.cpp
View file

@ -168,9 +168,6 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
}
if (can_have_declared_layout(class_names.last()) && "layout"sv.starts_with(identifier_string))
identifier_entries.empend("layout: ", identifier_string.length(), Language::Unspecified, "layout");
// No need to suggest anything if it's already completely typed out!
if (identifier_entries.size() == 1 && identifier_entries.first().completion == identifier_string)
identifier_entries.clear();
break;
}
case AfterClassName: {