RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:37:45 +00:00
Code Issues Activity Actions

LibIPC: Do not leak the Core::File fd by default

Browse source 
This prevents fd leaks when the user of the API forgets to pass
CloseAfterSending to IPC::File. Since we are calling leak_fd in the
constructor, we want it to also take care of closing.
This commit is contained in:
Sebastian Zaha 2023-07-10 15:52:26 +02:00 • committed by Tim Flynn
parent 318a3a0822
commit 88872ca42d
3 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibIPC/File.h
View file

@ -40,9 +40,8 @@ public:
{
}
template<typename... Args>
File(Core::File& file, Args... args)
: File(file.leak_fd(Badge<File> {}), args...)
explicit File(Core::File& file)
: File(file.leak_fd(Badge<File> {}), CloseAfterSending)
{
}