RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 09:17:35 +00:00
Code Issues Activity Actions

AK: Use size_t for ByteBuffer sizes

Browse source 
This matches what we already do for string types.
This commit is contained in:
Andreas Kling 2020-02-20 12:54:15 +01:00
parent 1dfc66c7cc
commit 88b9fcb976
14 changed files with 75 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/Ext2FileSystem.cpp
View file

@ -923,8 +923,10 @@ bool Ext2FSInode::write_directory(const Vector<FS::DirectoryEntry>& entries)
stream.fill_to_end(0);
ssize_t nwritten = write_bytes(0, directory_data.size(), directory_data.data(), nullptr);
if (nwritten < 0)
return false;
set_metadata_dirty(true);
return nwritten == directory_data.size();
return static_cast<size_t>(nwritten) == directory_data.size();
}
KResult Ext2FSInode::add_child(InodeIdentifier child_id, const StringView& name, mode_t mode)

9
Kernel/FileSystem/FileDescription.cpp
View file

@ -182,7 +182,10 @@ ssize_t FileDescription::get_dir_entries(u8* buffer, ssize_t size)
if (!metadata.is_valid())
return -EIO;
int size_to_allocate = max(PAGE_SIZE, metadata.size);
if (size < 0)
return -EINVAL;
size_t size_to_allocate = max(PAGE_SIZE, metadata.size);
auto temp_buffer = ByteBuffer::create_uninitialized(size_to_allocate);
BufferStream stream(temp_buffer);
@ -195,8 +198,8 @@ ssize_t FileDescription::get_dir_entries(u8* buffer, ssize_t size)
});
stream.snip();
if (size < temp_buffer.size())
return -1;
if (static_cast<size_t>(size) < temp_buffer.size())
return -EINVAL;
copy_to_user(buffer, temp_buffer.data(), temp_buffer.size());
return stream.offset();