RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:07:36 +00:00
Code Issues Activity Actions

Kernel: Remove is_sharing_with_others API from GenericInterruptHandler

Browse source 
is_sharing_with_others API was never really put to use properly since
it was introduced. The only place where it is used in Interrupts.cpp is
in conjuction with is_shared_handler() which is only true for
SharedIRQHandler and is_sharing_with_others will always return false.

Remove that API.
This commit is contained in:
Pankaj Raghav 2023-04-12 22:55:20 +02:00 • committed by Andreas Kling
parent 756a73471e
commit 8944ca830f
8 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Kernel/Interrupts/GenericInterruptHandler.h
View file

@ -41,7 +41,6 @@ public:
virtual size_t sharing_devices_count() const = 0;
virtual bool is_shared_handler() const = 0;
virtual bool is_sharing_with_others() const = 0;
virtual HandlerType type() const = 0;
virtual StringView purpose() const = 0;

1
Kernel/Interrupts/IRQHandler.h
View file

@ -31,7 +31,6 @@ public:
virtual size_t sharing_devices_count() const override { return 0; }
virtual bool is_shared_handler() const override { return false; }
virtual bool is_sharing_with_others() const override { return m_shared_with_others; }
void set_shared_with_others(bool status) { m_shared_with_others = status; }
protected:

1
Kernel/Interrupts/SharedIRQHandler.h
View file

@ -33,7 +33,6 @@ public:
return m_handlers.with([](auto& list) { return list.size_slow(); });
}
virtual bool is_shared_handler() const override { return true; }
virtual bool is_sharing_with_others() const override { return false; }
virtual HandlerType type() const override { return HandlerType::SharedIRQHandler; }
virtual StringView purpose() const override { return "Shared IRQ Handler"sv; }

1
Kernel/Interrupts/SpuriousInterruptHandler.h
View file

@ -28,7 +28,6 @@ public:
virtual size_t sharing_devices_count() const override { return 1; }
virtual bool is_shared_handler() const override { return false; }
virtual bool is_sharing_with_others() const override { return false; }
virtual HandlerType type() const override { return HandlerType::SpuriousInterruptHandler; }
virtual StringView purpose() const override;

1
Kernel/Interrupts/UnhandledInterruptHandler.h
View file

@ -25,7 +25,6 @@ public:
virtual size_t sharing_devices_count() const override { return 0; }
virtual bool is_shared_handler() const override { return false; }
virtual bool is_sharing_with_others() const override { return false; }
private:
};