From 8946c0c10493453f9875ac4ee20c716d2636a838 Mon Sep 17 00:00:00 2001 From: Lucas CHOLLET Date: Thu, 6 Jul 2023 23:03:47 -0400 Subject: [PATCH] LibGfx/DDS: Don't double-check the magic number This is already done in `decode_dds()`. --- Userland/Libraries/LibGfx/ImageFormats/DDSLoader.cpp | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/Userland/Libraries/LibGfx/ImageFormats/DDSLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/DDSLoader.cpp index 99ed735289..addf10fda8 100644 --- a/Userland/Libraries/LibGfx/ImageFormats/DDSLoader.cpp +++ b/Userland/Libraries/LibGfx/ImageFormats/DDSLoader.cpp @@ -634,15 +634,7 @@ IntSize DDSImageDecoderPlugin::size() ErrorOr DDSImageDecoderPlugin::initialize() { - // The header is always at least 128 bytes, so if the file is smaller, it can't be a DDS. - if (m_context->data_size > 128 - && m_context->data[0] == 0x44 - && m_context->data[1] == 0x44 - && m_context->data[2] == 0x53 - && m_context->data[3] == 0x20) - return {}; - - return Error::from_string_literal("Bad image magic"); + return {}; } bool DDSImageDecoderPlugin::sniff(ReadonlyBytes data)