RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibSQL: Remove and update VERIFYs

Browse source 
We are performing a lot of checks on pointers that are performed again
immediately afterwards because of a dereference. This removes the
redundant `VERIFY`s and simplifies a couple others.
This commit is contained in:
Jelle Raaijmakers 2023-04-19 18:58:56 +02:00 • committed by Tim Flynn
parent 036eb82aca
commit 8992ff5aeb
5 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibSQL/Serializer.h
View file

@ -28,7 +28,6 @@ public:
void get_block(u32 pointer)
{
VERIFY(m_heap.ptr() != nullptr);
auto buffer_or_error = m_heap->read_block(pointer);
if (buffer_or_error.is_error())
VERIFY_NOT_REACHED();
@ -110,7 +109,7 @@ public:
template<typename T>
bool serialize_and_write(T const& t)
{
VERIFY(m_heap.ptr() != nullptr);
VERIFY(!m_heap.is_null());
reset();
serialize<T>(t);
m_heap->add_to_wal(t.pointer(), m_buffer);
@ -120,20 +119,17 @@ public:
[[nodiscard]] size_t offset() const { return m_current_offset; }
u32 new_record_pointer()
{
VERIFY(m_heap.ptr() != nullptr);
return m_heap->new_record_pointer();
}
bool has_block(u32 pointer) const
{
VERIFY(m_heap.ptr() != nullptr);
return pointer < m_heap->size();
}
Heap& heap()
{
VERIFY(m_heap.ptr() != nullptr);
return *(m_heap.ptr());
return *m_heap;
}
private: