RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

LibSoftGPU: Simplify clipping logic

Browse source 
The clipping logic is not DRY (Don't Repeat Yourself). The same logic
is repeated in multiple parts of an `if-else` statement. This can be
simplified to contain fewer branches and eliminate the redundant code.
This commit is contained in:
Lenny Maiorani 2022-01-27 17:18:49 -07:00 • committed by Idan Horowitz
parent fa016a72fd
commit 899f062673
1 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibSoftGPU/Clipper.cpp
View file

@ -73,16 +73,15 @@ static void clip_plane(Vector<Vertex>& read_list, Vector<Vertex>& write_list, Cl
auto const& curr_vec = read_from->at((i + 1) % read_from->size()); auto const& curr_vec = read_from->at((i + 1) % read_from->size());
auto const& prev_vec = read_from->at(i); auto const& prev_vec = read_from->at(i);
if (point_within_clip_plane(curr_vec.clip_coordinates, plane)) { bool const is_curr_point_within_clip_plane = point_within_clip_plane(curr_vec.clip_coordinates, plane);
if (!point_within_clip_plane(prev_vec.clip_coordinates, plane)) { bool const is_prev_point_within_clip_plane = point_within_clip_plane(prev_vec.clip_coordinates, plane);
auto const intersect = clip_intersection_point(prev_vec, curr_vec, plane); if (is_curr_point_within_clip_plane != is_prev_point_within_clip_plane) {
write_to->append(intersect);
}
write_to->append(curr_vec);
} else if (point_within_clip_plane(prev_vec.clip_coordinates, plane)) {
auto const intersect = clip_intersection_point(prev_vec, curr_vec, plane); auto const intersect = clip_intersection_point(prev_vec, curr_vec, plane);
write_to->append(intersect); write_to->append(intersect);
} }
if (is_curr_point_within_clip_plane)
write_to->append(curr_vec);
} }
swap(write_list, read_list); swap(write_list, read_list);
} }