RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:07:34 +00:00
Code Issues Activity Actions

LibWeb: Convert some CSS parser *Rule classes to using pointers

Browse source 
Previously these were all passed around by value, but some of them
(StyleComponentValueRule and StyleBlockRule) want to include each
other as fields, so this had to change.
This commit is contained in:
Sam Atkins 2021-07-01 14:13:48 +01:00 • committed by Andreas Kling
parent a558916e1f
commit 89bfde29dc
7 changed files with 47 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibWeb/CSS/Parser/StyleComponentValueRule.h
View file

@ -7,12 +7,15 @@
#pragma once
#include <LibWeb/CSS/Parser/StyleBlockRule.h>
#include <LibWeb/CSS/Parser/StyleFunctionRule.h>
#include <AK/NonnullRefPtr.h>
#include <AK/RefPtr.h>
#include <LibWeb/CSS/Parser/Token.h>
namespace Web::CSS {
class StyleBlockRule;
class StyleFunctionRule;
class StyleComponentValueRule {
friend class Parser;
@ -27,10 +30,18 @@ public:
~StyleComponentValueRule();
bool is_block() const { return m_type == ComponentType::Block; }
StyleBlockRule const& block() const { return m_block; }
StyleBlockRule const& block() const
{
VERIFY(is_block());
return *m_block;
}
bool is_function() const { return m_type == ComponentType::Function; }
StyleFunctionRule const& function() const { return m_function; }
StyleFunctionRule const& function() const
{
VERIFY(is_function());
return *m_function;
}
bool is(Token::TokenType type) const
{
@ -44,7 +55,7 @@ public:
private:
ComponentType m_type;
Token m_token;
StyleFunctionRule m_function;
StyleBlockRule m_block;
RefPtr<StyleFunctionRule> m_function;
RefPtr<StyleBlockRule> m_block;
};
}