RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:57:34 +00:00
Code Issues Activity Actions

LibJS: Mark concrete method calls of Environment Records with ?/!

Browse source 
This is an editorial change in the ECMA-262 spec.

See: 7ae3ecf
This commit is contained in:
Linus Groh 2022-05-24 18:19:49 +01:00
parent cdc5ed2fb5
commit 89d4094709
3 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/DeclarativeEnvironment.cpp
View file

@ -131,8 +131,7 @@ ThrowCompletionOr<void> DeclarativeEnvironment::set_mutable_binding(GlobalObject
if (strict)
return vm().throw_completion<ReferenceError>(global_object, ErrorType::UnknownIdentifier, name);
// FIXME: Should be `! envRec.CreateMutableBinding(N, true)` (see https://github.com/tc39/ecma262/pull/2764)
// b. Perform envRec.CreateMutableBinding(N, true).
// b. Perform ! envRec.CreateMutableBinding(N, true).
MUST(create_mutable_binding(global_object, name, true));
// c. Perform ! envRec.InitializeBinding(N, V).