RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:37:35 +00:00
Code Issues Activity Actions

LibWeb: Fix duplicated clip overflow in child stacking contexts

Browse source 
`StackingContext::paint_child()` does not have to clip overflow because
callers of this method already do that.
This commit is contained in:
Aliaksandr Kalenik 2023-12-05 22:26:13 +01:00 • committed by Andreas Kling
parent 154d201d41
commit 89fd8dfaad
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -181,17 +181,11 @@ void StackingContext::paint_child(PaintContext& context, StackingContext const&
auto parent_paintable = child.paintable_box().parent(); auto parent_paintable = child.paintable_box().parent();
if (parent_paintable) if (parent_paintable)
parent_paintable->before_children_paint(context, PaintPhase::Foreground); parent_paintable->before_children_paint(context, PaintPhase::Foreground);
auto containing_block = child.paintable_box().containing_block();
auto* containing_block_paintable = containing_block ? containing_block->paintable() : nullptr;
if (containing_block_paintable)
containing_block_paintable->apply_clip_overflow_rect(context, PaintPhase::Foreground);
child.paint(context); child.paint(context);
if (parent_paintable) if (parent_paintable)
parent_paintable->after_children_paint(context, PaintPhase::Foreground); parent_paintable->after_children_paint(context, PaintPhase::Foreground);
if (containing_block_paintable)
containing_block_paintable->clear_clip_overflow_rect(context, PaintPhase::Foreground);
} }
void StackingContext::paint_internal(PaintContext& context) const void StackingContext::paint_internal(PaintContext& context) const
@ -259,8 +253,14 @@ void StackingContext::paint_internal(PaintContext& context) const
for (auto* child : m_children) { for (auto* child : m_children) {
if (!child->paintable_box().is_positioned()) if (!child->paintable_box().is_positioned())
continue; continue;
auto containing_block = child->paintable_box().containing_block();
auto const* containing_block_paintable = containing_block ? containing_block->paintable() : nullptr;
if (containing_block_paintable)
containing_block_paintable->apply_clip_overflow_rect(context, PaintPhase::Foreground);
if (child->paintable_box().computed_values().z_index().has_value() && child->paintable_box().computed_values().z_index().value() >= 1) if (child->paintable_box().computed_values().z_index().has_value() && child->paintable_box().computed_values().z_index().value() >= 1)
paint_child(context, *child); paint_child(context, *child);
if (containing_block_paintable)
containing_block_paintable->clear_clip_overflow_rect(context, PaintPhase::Foreground);
} }
paint_node(paintable_box(), context, PaintPhase::Outline); paint_node(paintable_box(), context, PaintPhase::Outline);