RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:27:46 +00:00
Code Issues Activity Actions

LibJS: Remove direct argument loading since it was buggy

Browse source 
The parser doesn't always track lexical scopes correctly, so let's not
rely on that for direct argument loading.

This reverts the LoadArguments bytecode instruction as well. We can
bring these things back when the parser can reliably tell us that
a given Identifier is indeed a function argument.
This commit is contained in:
Andreas Kling 2021-06-22 22:20:17 +02:00
parent 1082e99e08
commit 8a3c9d9851
9 changed files with 4 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/Reference.h
View file

@ -40,15 +40,6 @@ public:
{
}
enum CallFrameArgumentTag { CallFrameArgument };
Reference(CallFrameArgumentTag, size_t index, FlyString const& name)
: m_base(js_null())
, m_name(name)
, m_call_frame_argument_index(index)
, m_local_variable(true)
{
}
Value base() const { return m_base; }
const PropertyName& name() const { return m_name; }
bool is_strict() const { return m_strict; }
@ -83,7 +74,6 @@ private:
Value m_base;
PropertyName m_name;
Optional<size_t> m_call_frame_argument_index;
bool m_strict { false };
bool m_local_variable { false };
bool m_global_variable { false };